Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GeoIP - Download ready flag #3015

Open
ashoktelukuntla opened this issue Jul 12, 2023 · 2 comments
Open

[BUG] GeoIP - Download ready flag #3015

ashoktelukuntla opened this issue Jul 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ashoktelukuntla
Copy link
Contributor

ashoktelukuntla commented Jul 12, 2023

Describe the bug
Please address comments in issue : #2925

Issue : downloadReady flag and also global usage of this flag.

To Reproduce
Review comments to be addressed

@kkondaka
Copy link
Collaborator

@venkataraopasyavula can you take a look? And if this is not a bug please provide explanation.

@venkataraopasyavula
Copy link
Contributor

The default value of "downloadReady" is false. When downloadReady is false, the thread will be in wait() state.
The downloadReady flag will become true after download is completed and call notifyall() so that the wait state thread will resume and do further operation.
Download thread will be called based on the cache refresh schedule.
During enrichment the downloadReady flag will be chcked whether download is true or not.
If new download is available (i.e downloadReady = true) switch the reader. If downloadReady = false continue enrichment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants