Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Many Grok failures do not tag events #4031

Closed
dlvenable opened this issue Jan 30, 2024 · 1 comment · Fixed by #4032
Closed

[BUG] Many Grok failures do not tag events #4031

dlvenable opened this issue Jan 30, 2024 · 1 comment · Fixed by #4032
Assignees
@dlvenable
Labels
bug Something isn't working enhancement New feature or request
Milestone
v2.7

Comments

@dlvenable
Copy link
Member

Describe the bug

There are several exceptions which the grok processor catches that do not tag the event.

To Reproduce

Run a pipeline with a grok pattern than times out. The event is not tagged.

Expected behavior

I expect that any failure to match will result in a tag.
@dlvenable dlvenable added bug Something isn't working untriaged labels Jan 30, 2024
@dlvenable dlvenable self-assigned this Jan 30, 2024
dlvenable added a commit to dlvenable/data-prepper that referenced this issue Jan 30, 2024
@dlvenable
Tags events that fail for all exceptions. Resolves opensearch-project…
a52adae 
…#4031

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable mentioned this issue Jan 30, 2024
Merged
4 tasks
@dlvenable dlvenable added this to the v2.7 milestone Jan 30, 2024
@dlvenable dlvenable added the enhancement New feature or request label Jan 30, 2024
@dlvenable
Copy link
Member Author

We will support this by a new tags_on_timeout configuration in the grok processor.

dlvenable added a commit that referenced this issue Jan 30, 2024
@dlvenable
Tag events that fail for all exceptions in the grok processor. Resolves
96007d6 
#4031 (#4032)

Tags events that fail for all exceptions. Resolves #4031

Adds a tags_on_timeout configuration which tags events that timeout differently from those that fail for other reasons. Configure the default behavior of tags_on_timeout to take on the value of tags_on_match_failure.

Signed-off-by: David Venable <dlv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlvenable dlvenable

Labels
bug Something isn't working enhancement New feature or request
Projects
Data Prepper Tracking Board
Status: Done
Milestone
v2.7
Development

Successfully merging a pull request may close this issue.

Tag events that fail for all exceptions in the grok processor. Resolves #4031 dlvenable/data-prepper
1 participant
@dlvenable