Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature direction to AD docs #9137

Merged
merged 17 commits into from
Feb 4, 2025

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Jan 29, 2025

Description

Adding description so users know they can also select a feature direction when configuring a feature.

Issues Resolved

Closes #9118

Version

2.19

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.19.0 labels Jan 29, 2025
@@ -201,7 +205,7 @@ Be cautious when imputing extensively missing data, as excessive gaps can compro

### Suppressing anomalies with threshold-based rules

In the **Advanced settings** pane, you can suppress anomalies by setting rules that define acceptable differences between the expected and actual values, either as an absolute value or a relative percentage. This helps reduce false anomalies caused by minor fluctuations, allowing you to focus on significant deviations.
In the Feature selection pane, you can suppress anomalies by setting rules that define acceptable differences between the expected and actual values, either as an absolute value or a relative percentage. This helps reduce false anomalies caused by minor fluctuations, allowing you to focus on significant deviations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the suppression rules outside of its own to feature section. that makes it easier to find.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to update example snapshot in my example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this:

"Ensure that a feature, for example, logVolume, is properly defined in your model. Suppression rules are tied to specific features."

There is no photo snapshot currently in the docs but do you mean removing this:

Ignore anomalies for feature logVolume when the actual value is no more than 30% above the expected value.
Ignore anomalies for feature logVolume when the actual value is no more than 30% below the expected value.

and replace with screenshot of current UI?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think that would be more straightforward using screenshot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added 2 screenshots, still kept this wording though.

First screenshot has entire feature configuration and second just a zoom in of the suppression rules, let me know if you think its too much

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In images/anomaly-detection/add-suppression-rules-absolute.png, you need use "Units" in both rules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@Naarcha-AWS Naarcha-AWS added the 4 - Doc review PR: Doc review in progress label Jan 30, 2025
@Naarcha-AWS
Copy link
Collaborator

@amitgalitz: Looks good. Made some small adjustments. Can you look them over and make sure that the changes are still technically accurate?

Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
@kaituo
Copy link
Contributor

kaituo commented Feb 3, 2025

@Naarcha-AWS The change looks good.

@Naarcha-AWS
Copy link
Collaborator

@natebower: This is ready for your review.

@Naarcha-AWS Naarcha-AWS added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Feb 3, 2025
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naarcha-AWS @amitgalitz Please see my comments and changes and tag me for approval when addressed. Thanks!

_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
_observing-your-data/ad/index.md Show resolved Hide resolved
- Ignore anomalies when the actual value is no more than 30% above the expected value.
- Ignore anomalies when the actual value is no more than 30% below the expected value.

The following image shows where to set the relative deviation percentage settings:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name what is shown in the image: "The following image shows the X page/window/pane, where you can set the relative deviation percentage settings:"

- Ignore anomalies when the actual value is no more than 10000 above the expected value.
- Ignore anomalies when the actual value is no more than 10000 below the expected value.

The following image shows where to set the absolute threshold settings:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name what is shown in the image: "The following image shows the X page/window/pane, where you can set the absolute threshold settings:"

Naarcha-AWS and others added 3 commits February 4, 2025 07:05
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Co-authored-by: Nathan Bower <nbower@amazon.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Signed-off-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a line removal. Thanks!

_observing-your-data/ad/index.md Outdated Show resolved Hide resolved
@Naarcha-AWS Naarcha-AWS merged commit f8edf06 into opensearch-project:main Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Anomaly Detection Feature Direction documentation
5 participants