Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make Thread Pool available to Process Node #42

Closed
dbwiddis opened this issue Sep 16, 2023 · 0 comments · Fixed by #47 or #66
Closed

[FEATURE] Make Thread Pool available to Process Node #42

dbwiddis opened this issue Sep 16, 2023 · 0 comments · Fixed by #47 or #66
Assignees
Labels
enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Sep 16, 2023

Is your feature request related to a problem?

The ProcessNode.execute() method introduced in #26 executes a workflow step asynchronously. This execution should share resources with the OpenSearch thread pool.

What solution would you like?

PR #38 will be adding the create components extension point which includes the Thread Pool. This pool needs to be accessible in some way to the Process Node class.

Presently the TemplateParser class uses static methods, but this class can probably be turned into a singleton, instantiated as part of the createComponents method execution with a copy of the thread pool, that it can pass on to the ProcessNode in its constructor.

What alternatives have you considered?

There may be other ways to pass around the threadpool in a static or singleton class somewhere.

Do you have any additional context?

Using the OpenSearch Thread Pool is pretty much mandatory for properly sharing resources and tracking thread stats / hot threads, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants