Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update deprovisioning to use retry on delete model #726

Closed
dbwiddis opened this issue Jun 1, 2024 · 1 comment
Closed

[FEATURE] Update deprovisioning to use retry on delete model #726

dbwiddis opened this issue Jun 1, 2024 · 1 comment
Labels
backlog Good to have functionality not critical for next release enhancement New feature or request

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jun 1, 2024

Is your feature request related to a problem?

Currently we use a ~100ms time delay in deprovisioning to overcome a race condition where deleting a model immediately after undeploying it would fail.

ML Commons is adding a retry capability to the delete step which would avoid the need for this time delay.

What solution would you like?

Update our code when the above linked PR is merged, to use a retry delay on the delete request, rather than our own time delay.

What alternatives have you considered?

Leave it as-is.

Do you have any additional context?

We still may need some delay regarding deleting connectors if the model isn't deleted, so this may not be a complete fix-all, but should at least make deprovisioning more robust.

@dbwiddis dbwiddis added enhancement New feature or request untriaged backlog Good to have functionality not critical for next release and removed untriaged labels Jun 1, 2024
@dbwiddis dbwiddis removed the untriaged label Jun 6, 2024
@dbwiddis
Copy link
Member Author

dbwiddis commented Jun 7, 2024

Closing as the linked proposal was closed.

@dbwiddis dbwiddis closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Good to have functionality not critical for next release enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant