Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compile failure with new MLTask Constructor #858

Closed
dbwiddis opened this issue Sep 6, 2024 · 0 comments · Fixed by #859
Closed

[BUG] Compile failure with new MLTask Constructor #858

dbwiddis opened this issue Sep 6, 2024 · 0 comments · Fixed by #859
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Sep 6, 2024

What is the bug?

opensearch-project/ml-commons#2825 added a new parameter to the constructor. We use that in a test:

src/test/java/org/opensearch/flowframework/workflow/RegisterLocalPretrainedModelStepTests.java:140: error: no suitable constructor found for MLTask(String,String,,,MLTaskState,,,,,,,,,boolean)

How can one reproduce the bug?

Attempt to compile the code with current upstream dependencies.

Specifically:

./gradlew compileTestJava

(If it passes, you probably have cached dependencies.)

What is the expected behavior?

Code compiles.

What is your host/environment?

Multiple environments failed in #856 but you can probably reproduce it anywhere.

Do you have any additional context?

The constructor is annotated @Builder so we should change that line of code to use a builder (omitting the nulls) to be robust to future changes.

This needs to be fixed promptly and backported to 2.17.

@dbwiddis dbwiddis added bug Something isn't working good first issue Good for newcomers untriaged and removed untriaged labels Sep 6, 2024
@opensearch-project opensearch-project deleted a comment from junweid62 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants