Skip to content

Default size to 100 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Default size to 100 #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ca76e
default size to 100 if size is not set
yyfamazon Nov 3, 2025
413e630
Default size to 100
yyfamazon Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/opensearch/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ def search_index(args: SearchIndexArgs) -> json:
from .client import initialize_client

client = initialize_client(args)
response = client.search(index=args.index, body=args.query)

# Set default size to 100 if not present in query body
query = args.query.copy() if isinstance(args.query, dict) else args.query
if isinstance(query, dict) and 'size' in query:
query['size'] = min(100, query['size'])
Copy link
Collaborator

@rithin-pullela-aws rithin-pullela-aws Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean we would not be able to send a size > 100.

I believe this kind of restriction is not ideal, can we make it configurable in settings?

Copy link
Collaborator

@rithin-pullela-aws rithin-pullela-aws Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a similar PR has already been raised in #114

Copy link
Author

@yyfamazon yyfamazon Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I close my pr if a similar PR has already been raised ?


response = client.search(index=args.index, body=query)
return response


Expand Down
Loading