Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test name mismatch #681

Open
noCharger opened this issue Sep 19, 2024 · 0 comments
Open

[BUG] Test name mismatch #681

noCharger opened this issue Sep 19, 2024 · 0 comments
Labels
bug Something isn't working untriaged

Comments

@noCharger
Copy link
Collaborator

What is the bug?

https://github.com/opensearch-project/opensearch-spark/blob/f283df840170fdb305324f042de303b03e7e0190/integ-test/src/integration/scala/org/opensearch/flint/spark/FlintSparkCoveringIndexITSuite.scala#L101C1-L120C4

  test("incremental refresh covering index successfully") {
    flint
      .coveringIndex()
      .name(testIndex)
      .onTable(testTable)
      .addIndexColumns("name", "age")
      .options(FlintSparkIndexOptions(Map("auto_refresh" -> "true")))
      .create()

    val jobId = flint.refreshIndex(testFlintIndex)
    jobId shouldBe defined

    val job = spark.streams.get(jobId.get)
    failAfter(streamingTimeout) {
      job.processAllAvailable()
    }

    val indexData = flint.queryIndex(testFlintIndex)
    checkAnswer(indexData, Seq(Row("Hello", 30), Row("World", 25)))
  }

Test name is incremental refresh but it actually runs auto refresh. Need to add test case for incremental refresh accordingly

@noCharger noCharger added bug Something isn't working untriaged labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

1 participant