Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ResultSet.getTime(index, calendar) returns null #20

Open
kylepbit opened this issue Oct 19, 2022 · 2 comments
Open

[BUG] ResultSet.getTime(index, calendar) returns null #20

kylepbit opened this issue Oct 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@kylepbit
Copy link

What is the bug?
Retrieving time with a calendar always returns null.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Have some time data
  2. Invoke ResultSet.getTime(index, calendar) to try and get the time
  3. See null as the result, always

Looking at the code, it's simply hardcoded to return null.

What is the expected behavior?
A non-null value reflecting the retrieved time.

What is your host/environment?

  • OS: macOS
  • Version JDBC 1.1.0.1
  • Plugins
@kylepbit kylepbit added the bug Something isn't working label Oct 19, 2022
@Yury-Fridlyand
Copy link
Collaborator

https://github.com/opensearch-project/sql/blob/4b50a014c6f5701f3061ad950073895b39f68a67/sql-jdbc/src/main/java/org/opensearch/jdbc/ResultSetImpl.java#L1072-L1082

@acarbonetto
Copy link
Collaborator

Note: getDate and getTimestamp is already implemented for this feature, and it seems like getTime is simple enough to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants