Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPRUN-3711: OLMv1: Get catalogd image from operator-controller repo #6027

Merged

Conversation

tmshort
Copy link

@tmshort tmshort commented Jan 27, 2025

We are merging the catalogd repo into operator-controller

Verified

This commit was signed with the committer’s verified signature.
tmshort Todd Short
We are merging the catalogd repo into operator-controller

Signed-off-by: Todd Short <todd.short@me.com>
@tmshort tmshort changed the title OPROLMv1: Get catalogd image from operator-controller repo OPRUN-3711: OLMv1: Get catalogd image from operator-controller repo Jan 27, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 27, 2025

@tmshort: This pull request references OPRUN-3711 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

We are merging the catalogd repo into operator-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmshort
Copy link
Author

tmshort commented Jan 27, 2025

What should we do it with https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.19/images/ose-olm-catalogd.yml , should we delete it?

That's the file this PR modifies? We shouldn't delete it AFAICT.

@ashwindasr
Copy link
Contributor

/hold

Until test build succeeds: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=66496681

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
Copy link

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
Copy link
Contributor

@ashwindasr ashwindasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, LalatenduMohanty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@ashwindasr ashwindasr added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b6a66fd into openshift-eng:openshift-4.19 Jan 28, 2025
2 checks passed
@tmshort tmshort deleted the combine-catd-op-con branch January 28, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants