Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use imagestream instead of image #101

Open
AsherShoshan opened this issue Feb 26, 2020 · 2 comments
Open

use imagestream instead of image #101

AsherShoshan opened this issue Feb 26, 2020 · 2 comments

Comments

@AsherShoshan
Copy link

in DeploymentConfig, the imagestream should be used instead ogf the 'normal' image
https://github.com/openshift-kni/cnf-features-deploy/blob/master/feature-configs/demo/dpdk/deployment-config.yaml#L34-L36

@slintes
Copy link
Member

slintes commented Feb 27, 2020

@SchSeba is that something you can handle?

@SchSeba
Copy link
Member

SchSeba commented Feb 27, 2020

Hi @AsherShoshan the part is a PodSpec resource there is no imagestream there.

You can validate that by change it and try to run oc apply -f <yaml> it should fail.

The imagestream is in the trigger part that will update the deployment every time a new image was pushed to the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants