-
Notifications
You must be signed in to change notification settings - Fork 258
Expand file tree
/
Copy path.coderabbit.yaml
More file actions
25 lines (25 loc) · 1.64 KB
/
.coderabbit.yaml
File metadata and controls
25 lines (25 loc) · 1.64 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
reviews:
path_instructions:
- path: hack/app-sre/saas-template.yaml
instructions: |
This file is generated by injecting the objects in saas-objects.yaml into the stub at
saas-template-stub.yaml. Other than checking that that has been done cleanly, any reviews of
this file should be redundant with those for files under config/crds and should therefore be
skipped.
- path: hack/app-sre/saas-objects.yaml
instructions: |-
This file is generated by kustomize-ing the CRDs defined under config/crds. Other than
checking that that has been done cleanly, any reviews of this file should be redundant with
those for the CRD YAML files themselves and should therefore be skipped.
- path: config/crds/**.yaml
instructions: |-
These files are generated by codegen from kubebuilder-tagged data types defined under
[vendor/github.com/openshift/hive/]apis/hive.
- Both copies of a given *_types.go file under those paths should be identical. We have a CI
check to validate this; but feel free to drop a comment if you find this is not the case.
- When reviewing the CRD schemas, please trace back and take note of the type file from which
the section under scrutiny was generated. Only comment if that file belongs to hive. That is,
skip inherited definitions from vendored type files. (Note that hive's type definitions are
copied into vendor directories for generation. These are the ones we care about. So when I say
"skip inherited definitions from vendored type files" I mean those with `vendor/` in the path
*unless* it's `vendor/github.com/openshift/hive/...`.)