Skip to content

Conversation

@elmiko
Copy link

@elmiko elmiko commented Oct 29, 2025

  • pass allNodes to node info provider Process

This change passes all the nodes to the mixed node info provider processor that is called from RunOnce. The change is to allow unschedulable and unready nodes to be processed as bad canidates during the node info template generation.

The Process function has been updated to separate nodes into good and bad candidates to make the filtering match the original intent.

  • add --scale-from-unschedulable flag

This change introduces a flag which will instruct the CA to ignore a node's .spec.unschedulable field when creating node template for considering which node group to scale.

…nodes (kubernetes#8520)

* pass allNodes to node info provider Process

This change passes all the nodes to the mixed node info provider
processor that is called from `RunOnce`. The change is to allow
unschedulable and unready nodes to be processed as bad canidates during
the node info template generation.

The Process function has been updated to separate nodes into good and
bad candidates to make the filtering match the original intent.

* add --scale-from-unschedulable flag

This change introduces a flag which will instruct the CA to ignore a
node's `.spec.unschedulable` field when creating node template for
considering which node group to scale.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 29, 2025
@openshift-ci-robot
Copy link

@elmiko: This pull request references Jira Issue OCPBUGS-63678, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-63676 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

  • pass allNodes to node info provider Process

This change passes all the nodes to the mixed node info provider processor that is called from RunOnce. The change is to allow unschedulable and unready nodes to be processed as bad canidates during the node info template generation.

The Process function has been updated to separate nodes into good and bad candidates to make the filtering match the original intent.

  • add --scale-from-unschedulable flag

This change introduces a flag which will instruct the CA to ignore a node's .spec.unschedulable field when creating node template for considering which node group to scale.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@elmiko
Copy link
Author

elmiko commented Oct 29, 2025

/test e2e-aws-periodic-pre

@openshift-ci openshift-ci bot requested review from JoelSpeed and frobware October 29, 2025 14:36
@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko
Copy link
Author

elmiko commented Oct 29, 2025

/test e2e-aws-periodic-pre

@openshift-ci
Copy link

openshift-ci bot commented Oct 29, 2025

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a8e0dd6 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants