Add OCP tests extention #2461
Add OCP tests extention #2461
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Enable in origin PR: openshift/origin#29546 |
|
/retest |
|
/test images |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ed92a30-edf0-11ef-9c0e-969e451224c9-0 |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546 |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f56add10-edf0-11ef-9bb1-df918fe19020-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
f7d3e2a to
5814df7
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0be960-edfe-11ef-80e0-5a872e60b37d-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
7 times, most recently
from
183536a to
d2fb4a5
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f7faaa0-ef75-11ef-96a2-28660f14b785-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
d2fb4a5 to
9943987
Compare
openshift-merge-robot
added
the
needs-rebase
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
2 times, most recently
from
63ccc62 to
effa544
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
effa544 to
4497133
Compare
stbenjam
left a comment
stbenjam
left a comment
There was a problem hiding this comment.
This is awesome!!!! A few things I noticed
There was a problem hiding this comment.
Test names don't match up which cause some problems -- we won't be able to compare across releases for regressions.
Because these tests also exist in origin, origin won't know to override the internal test with the external one.
I see it two options:
- Keep the new names, but try to create a rename mapping file for ci-test-mapping to link up the renames. And remove the existing tests in origin.
- Make the names match somehow
origin:
[sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller pod connected to ClusterUserDefinedNetwork CR & managed NADs cannot be deleted when being used [Suite:openshift/conformance/parallel]
ovnk-tests-ext:
[ovn-kubernetes][Feature:NetworkSegmentation] ClusterUserDefinedNetwork CRD Controller pod connected to ClusterUserDefinedNetwork CR & managed NADs cannot be deleted when being used [Suite:openshift/conformance/parallel]
There was a problem hiding this comment.
Keep the new names, but try to create a rename mapping file for ci-test-mapping to link up the renames. And remove the existing tests in origin.
Yea, I went with renaming in-order to be consistent. Thats still WIP upstream but i cherry-picked it here for test.
There was a problem hiding this comment.
Working on renaming PR tomorrow.
| ovnTestsExtension.AddSuite(e.Suite{ | ||
| Name: "ovn-kubernetes/conformance/serial", | ||
| Parents: []string{ | ||
| "openshift/conformance/serial", | ||
| }, | ||
| Qualifiers: []string{`!labels.exists(l, l == "Serial") && labels.exists(l, l == "Conformance")`}, | ||
| }) |
There was a problem hiding this comment.
The suites code isn't implemented yet (origin will select tests based on [Suite:xyz] currently) -- but you'll want to include parallel here for when it does. I see some parallel tests in list tests, but no suites config for it here.
There was a problem hiding this comment.
True - oops. I mixed it up. I meant to be optimised and try put all tests as parallel and if we see problems, switch to serial. Updated. PTAL.
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
4497133 to
c85defb
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d7781c0-f434-11ef-8801-1e469e8c62a6-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
c85defb to
19627b7
Compare
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8e439030-cc5e-11f0-8c1c-3d8a3f3a00ef-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#30543 |
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/df224ac0-cebe-11f0-8ad1-d9f60a571da9-0 |
pperiyasamy
force-pushed
the
init-ocp-extensions-net-seg
branch
from
e57167c to
9f3b67f
Compare
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#30543 |
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f01604d0-d03e-11f0-94db-e4ebaa888fe2-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#30543 |
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ca966b30-d072-11f0-946d-93ba41c9b541-0 |
jluhrsen
force-pushed
the
init-ocp-extensions-net-seg
branch
from
9f3b67f to
e368811
Compare
| if len(cmd) == 0 { | ||
| panic("ExecK8NodeCommand(): insufficient command arguments") | ||
| } | ||
| cmd = append([]string{"debug", fmt.Sprintf("node/%s", nodeName), "--to-namespace=default", |
There was a problem hiding this comment.
@pperiyasamy , I think this --to-namespace=default is what we need here. I just rebase -i to get it here.
I think our errors like this:
failed to run command "/usr/bin/oc debug node/host2.cluster11.ocpci.eng.rdu2.redhat.com -- chroot /host mkdir -p /var/log/e2e-dbs/CR_&_managed_NADs_cannot_be_deleted_when_being_used-network-segmentation-2e103b60" on node host2.cluster11.ocpci.eng.rdu2.redhat.com: exit status 1, stdout: , stderr: error: unable to get namespace namespaces "ci-op-nd4thg27" not found
are coming because the 'oc' command is still stuck in a namespace that was cleaned up and deleted it.
I recreated it here:
❯ oc project amo
Already on project "amo" on server "https://api.jamo-4.21-ote-001.sdn.azure.devcluster.openshift.com:6443".
❯ oc project
Using project "amo" on server "https://api.jamo-4.21-ote-001.sdn.azure.devcluster.openshift.com:6443".
❯ oc debug node/jamo-4-21-ote-001-bt5vr-master-0
Temporary namespace openshift-debug-wtk4s is created for debugging node...
Starting pod/jamo-4-21-ote-001-bt5vr-master-0-debug-q4hpk ...
To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
Pod IP: 10.0.0.4
If you don't see a command prompt, try pressing enter.
sh-5.1# exit
exit
Removing debug pod ...
Temporary namespace openshift-debug-wtk4s was removed.
❯ oc delete namespace amo
namespace "amo" deleted
❯ oc debug node/jamo-4-21-ote-001-bt5vr-master-0
error: unable to get namespace namespaces "amo" not found
❯ oc debug node/jamo-4-21-ote-001-bt5vr-master-0 --to-namespace=default
Starting pod/jamo-4-21-ote-001-bt5vr-master-0-debug-4hxmv ...
To use host binaries, run `chroot /host`. Instead, if you need to access host namespaces, run `nsenter -a -t 1`.
Pod IP: 10.0.0.4
If you don't see a command prompt, try pressing enter.
sh-5.1# exit
exit
Removing debug pod ...
I didn't dig enough yet, but I wonder if wherever we are deleting our test/temp namespaces if we should be then just switching back to the default project.
either way, will be testing with this change and hopefully we can see some more tests passing.
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview openshift/origin#30543 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview openshift/origin#30543 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/92952030-d0b5-11f0-9a7e-968e7e975655-0 |
OCP doesn't use Feature:X but OCPFeature:X. Override the label 'key'. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
Limited suite of tests enabled - mainly net seg tests. This is the implementation of the tests extention API [1] [1] https://github.com/openshift-eng/openshift-tests-extension Signed-off-by: Martin Kennelly <mkennell@redhat.com> Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
Add openshift provider. Limit API implemented. Follow on work in PR 2641 is required to implement most of the API. This commit enables the bare-min of the API to get the current net-seg tests passing. Signed-off-by: Martin Kennelly <mkennell@redhat.com> Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
test,egressip: skip test if worker nodes < 3 Metal platform is slow, and we can see it take over 4 minutes sometimes for the UDN pod to become ready. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
init-ocp-extensions-net-seg
branch
from
e368811 to
aa901c2
Compare
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#30543 |
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95831820-d154-11f0-8f9e-59ea25a58151-0 |
It also moves from u/s k8s dependency to d/s to check if it uses right calculation for image index. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
pperiyasamy
force-pushed
the
init-ocp-extensions-net-seg
branch
from
aa901c2 to
d663290
Compare
|
The previous metal run just passed without running any tests from ote binary, seems like specs must be retrieved with |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#29546 |
|
@pperiyasamy: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#29546 |
|
/uncc |
|
@pperiyasamy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a398340-d1c1-11f0-8073-64359036a700-0 |
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
10 participants
/hold
/cc