Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search form design updates #124

Open
vanderburgt opened this issue Sep 28, 2023 · 5 comments
Open

Search form design updates #124

vanderburgt opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@vanderburgt
Copy link
Collaborator

Several design updates in response to testing outcomes.

Design

Image
Figma: https://www.figma.com/file/Tcv7xuwikoVW0U8c0pqDDq/Graphics?type=design&node-id=898-206&mode=design&t=Tp4V5yymIoBCSLQi-4

Changes

  • Single block for both the search fields and 'create alert' fields (to focus user attention)
  • Added field labels (replacing the in-field icons which were confusing)
  • Added help texts to search fields (for later testing)
  • Made query and locations fields full-width (related to: Vertically expanding full-width search fields #123)
  • Moved frequency select field to 'create alert' fields (to cope with spam concerns)
  • Added help text about unsubscribe (to cope with spam concerns)

Screencast

124.mov
@vanderburgt vanderburgt added the enhancement New feature or request label Oct 3, 2023
breyten added a commit that referenced this issue Oct 3, 2023
@breyten breyten closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Bron Roadmap 🚀✨ Oct 3, 2023
@vanderburgt vanderburgt reopened this Oct 4, 2023
@vanderburgt vanderburgt moved this from Done to To test in Bron Roadmap 🚀✨ Oct 4, 2023
@breyten breyten closed this as completed Oct 4, 2023
@github-project-automation github-project-automation bot moved this from To test to Done in Bron Roadmap 🚀✨ Oct 4, 2023
@vanderburgt vanderburgt moved this from Done to To test in Bron Roadmap 🚀✨ Oct 4, 2023
@vanderburgt
Copy link
Collaborator Author

Great! ✨

Some points of attention:

  • Form bg should have no drop shadow
  • Form background should be #F9F9FA (both parts)
  • Check form margins (see screenshot A below)
  • Check the select input field margins (see screenshot B below) and font size (inherit from body)
  • When the location input field (Zoekgebied) has more than two rows the top and bottom margins reduce. They should remain 11px or equivalent.

Screenshots

Screenshot A
Image
Screenshot B
Image

@vanderburgt vanderburgt reopened this Oct 4, 2023
breyten added a commit that referenced this issue Oct 6, 2023
breyten added a commit that referenced this issue Oct 6, 2023
@vanderburgt vanderburgt moved this from To test to Todo in Bron Roadmap 🚀✨ Oct 9, 2023
@vanderburgt
Copy link
Collaborator Author

vanderburgt commented Oct 9, 2023

Only item 2 is done.

  • Form bg should have no drop shadow
  • Form background should be #F9F9FA (both parts)
  • Check form margins (see screenshot A below)
  • Check the select input field margins (see screenshot B below) and font size (inherit from body)
  • When the location input field (Zoekgebied) has more than two rows the top and bottom margins reduce. They should remain 11px or equivalent.

@vanderburgt vanderburgt moved this from Todo to In Progress in Bron Roadmap 🚀✨ Oct 9, 2023
breyten added a commit that referenced this issue Oct 16, 2023
@breyten breyten moved this from In Progress to To test in Bron Roadmap 🚀✨ Oct 24, 2023
@vanderburgt vanderburgt moved this from To test to In Progress in Bron Roadmap 🚀✨ Oct 24, 2023
@vanderburgt
Copy link
Collaborator Author

vanderburgt commented Oct 24, 2023

See comment above, plus:

  • Dropdown arrow (chevron) of the frequency select field should be removed
  • X icon in location select field should be removed

@vanderburgt
Copy link
Collaborator Author

vanderburgt commented Oct 25, 2023

See comments above, plus:

  • - [ ] For the "Meer opties" checkboxes, suggested css value: "margin: 10px 10px 10px 0px;"
    Image

@breyten
Copy link
Member

breyten commented Oct 25, 2023

Regarding location select on multiple rows: I can get it correctly on either one row or multiple rows, but not both at the same time.

breyten added a commit that referenced this issue Oct 25, 2023
@breyten breyten moved this from In Progress to To test in Bron Roadmap 🚀✨ Oct 25, 2023
@vanderburgt vanderburgt moved this from To test to Done in Bron Roadmap 🚀✨ Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Released 🌈
Development

No branches or pull requests

2 participants