From bca0508cff18195190d59640f7719bb3dae7da47 Mon Sep 17 00:00:00 2001 From: Dante Soares Date: Thu, 13 May 2021 17:44:23 -0500 Subject: [PATCH] Renamed dropped_method to drop_method --- .../api/v1/tasks/tasked_exercise_representer.rb | 9 ++++++++- app/subsystems/tasks/models/tasked_exercise.rb | 2 +- .../tasks/tasked_exercise_representer_shared_examples.rb | 2 +- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/app/representers/api/v1/tasks/tasked_exercise_representer.rb b/app/representers/api/v1/tasks/tasked_exercise_representer.rb index 4e5aa38a4e..8a7106ac60 100644 --- a/app/representers/api/v1/tasks/tasked_exercise_representer.rb +++ b/app/representers/api/v1/tasks/tasked_exercise_representer.rb @@ -185,9 +185,16 @@ class TaskedExerciseRepresenter < TaskStepRepresenter writeable: false, if: FEEDBACK_AVAILABLE - property :dropped_method, + property :drop_method, type: String, readable: true, writeable: false + + # TODO: Remove after 1 release + property :dropped_method, + type: String, + readable: true, + writeable: false, + getter: ->(*) { drop_method } end end diff --git a/app/subsystems/tasks/models/tasked_exercise.rb b/app/subsystems/tasks/models/tasked_exercise.rb index fd54c9b347..bf8e689238 100644 --- a/app/subsystems/tasks/models/tasked_exercise.rb +++ b/app/subsystems/tasks/models/tasked_exercise.rb @@ -306,7 +306,7 @@ def published_comments end end - def dropped_method + def drop_method dropped_question = task_step.task&.task_plan&.dropped_questions&.find do |dq| dq.question_id == question_id end diff --git a/spec/representers/api/v1/tasks/tasked_exercise_representer_shared_examples.rb b/spec/representers/api/v1/tasks/tasked_exercise_representer_shared_examples.rb index 662bc6cc3e..76d4a34257 100644 --- a/spec/representers/api/v1/tasks/tasked_exercise_representer_shared_examples.rb +++ b/spec/representers/api/v1/tasks/tasked_exercise_representer_shared_examples.rb @@ -48,7 +48,7 @@ allow(exercise).to receive(:published_late_work_point_penalty).and_return(0.25) allow(exercise).to receive(:published_points).and_return(0.5) allow(exercise).to receive(:published_comments).and_return('Hi') - allow(exercise).to receive(:dropped_method).and_return(nil) + allow(exercise).to receive(:drop_method).and_return(nil) allow(exercise).to receive(:cache_key).and_return('tasks/models/tasked_exercises/42') allow(exercise).to receive(:cache_version).and_return('test') end