Skip to content

Commit 30b2b85

Browse files
committed
use page title as fallback if preview can't be parsed
1 parent 27fb57a commit 30b2b85

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

app/subsystems/tasks/models/tasked_reading.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ def has_learning_objectives?
1616
end
1717

1818
def content_preview
19-
text = document_title.presence || data_title.presence || class_title.presence
20-
text || "Reading Step ##{id}"
19+
document_title.presence || data_title.presence || class_title.presence || task_step.page.title
2120
end
2221

2322
private

spec/subsystems/tasks/models/tasked_reading_spec.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
it { is_expected.to validate_presence_of(:content) }
1010

1111
describe '#content_preview' do
12-
let(:default_reading_copy) { "Reading Step ##{tasked_reading.id}" }
1312

1413
before do
1514
tasked_reading.content = content
@@ -77,8 +76,8 @@
7776
HTML
7877
end
7978

80-
it "defaults to an expected copy" do
81-
expect(tasked_reading.content_preview).to eq(default_reading_copy)
79+
it "defaults to page title" do
80+
expect(tasked_reading.content_preview).to eq(tasked_reading.task_step.page.title)
8281
end
8382
end
8483
end

0 commit comments

Comments
 (0)