Speed Limit Field showing mph in placeholder even in regions that use km/h

[andrewharvey]

URL

https://www.openstreetmap.org/edit?locale=en-AU#map=18/-33.837903/151.238822

How to reproduce the issue?

create/select a road without a speed limit, and see the placeholder on the speed limit field

strangely I can't see this in any of the netlify releases, or in a local development environment of develop, but I can't see this as being fixed or changed recently.

Screenshot(s) or anything else?

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

No response

Which browsers are you seeing this problem on?

No response

[1ec5]

This is coming from Transifex: maxspeed, maxspeed:advisory, maxspeed:hgv. It looks like someone added the “mph” suffixes a few months ago.

[andrewharvey]

Thanks! Myself and @ForgottenHero (who found this issue originally) searched Transifex but couldn't find it.

In my view, all the more reason we need to bring translations back into GitHub as PRs with a discussion and review.

[1ec5]

Thanks! Myself and @ForgottenHero (who found this issue originally) searched Transifex but couldn't find it.

For future reference, I found these strings by searching for key:'maxspeed' in the Australian English localization, knowing that these placeholder strings are tied to id-tagging-schema’s maxspeed, maxspeed:advisory, and maxspeed:hgv fields. The History tab shows the change that took place three months ago.

In my view, all the more reason we need to bring translations back into GitHub as PRs with a discussion and review.

GitHub is not a translation management system; it doesn’t support most of the tools that (especially non-English) translators rely on. There are reasonable arguments for migrating to a different TMS, but doing away with any TMS would make the situation even more desperate than what JOSM is experiencing.

Currently, there’s a build script that we only run during the release process, so the only paper trail is a massive change to one of the many minified files in 6ed542a. Other projects I’ve worked on rely on either pulling translations from Transifex more manually and frequently in explicit pull requests, or configuring Transifex to open those PRs automatically (similar to how Dependabot works). Either approach would make it easier for folks like you to audit what goes into the localization.

If you’re concerned about fly-by-night contributions, a less drastic step would be to give you Reviewer permissions on Transifex and configuring the script to only pull approved translations. It would be up to you to manually approve any changes. I got iD’s original developers to configure Vietnamese this way because of someone who had persistently abused iD as a training ground for their (quite poor) machine translation tool:

iD/scripts/update_locales.js

Line 9 in ac3fe66

const reviewedOnlyLangs = ['vi'];

[andrewharvey]

Other projects I’ve worked on rely on either pulling translations from Transifex more manually and frequently in explicit pull requests, or configuring Transifex to open those PRs automatically. Either approach would make it easier for folks like you to audit what goes into the localization.

That sounds ideal.

Especially since many of the translations need extensive community discussion, while I've had ad-hoc discussions on Discord for some, it's best to have a place which stores better record of these discussions.

If you’re concerned about fly-by-night contributions, a less drastic step would be to give you Reviewer permissions on Transifex and configuring the script to only pull approved translations. It would be up to you to manually approve any changes. I got iD’s original developers to configure Vietnamese this way because of someone who had used iD as a training ground for their (quite poor) machine translation tool:

I have Reviewer permissions already, but I was always confused what marking a translation as "Reviewed" did. I tried to find a way to receive an email notification when there was a new translation made for review but I couldn't find such an option. While it's nice to have this option, I think it would put too much responsibility on me.

[1ec5]

Especially since many of the translations need extensive community discussion, while I've had ad-hoc discussions on Discord for some, it's best to have a place which stores better record of these discussions.

You can leave a comment in the Comments tab or create an “issue” there that pings the maintainers. Notably, this feature is only available to people who are already part of one of the translation teams. Some other TMSes allow more wide-ranging discussion, such as Translatewiki.net’s talk pages. #7508 discusses potentially migrating from Transifex to another TMS. Regardless, there’s nothing wrong with discussing strings on GitHub, as you did here.

I have Reviewer permissions already, but I was always confused what marking a translation as "Reviewed" did. I tried to find a way to receive an email notification when there was a new translation made for review but I couldn't find such an option. While it's nice to have this option, I think it would put too much responsibility on me.

Currently, reviewing an Australian English string makes no difference, because the script pulls all the saved translations regardless of review status. You can watch the iD project, but this may result in many notifications about other languages that you probably aren’t interested in. (At least that’s been my experience as a project maintainer.) Unfortunately, I don’t know of any way to watch only one language.