Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order of travis publish #238

Open
lastquestion opened this issue Jul 19, 2018 · 0 comments
Open

Change order of travis publish #238

lastquestion opened this issue Jul 19, 2018 · 0 comments

Comments

@lastquestion
Copy link
Contributor

When on master, we should

  1. Build styleguide
  2. Push styleguide
  3. Push to master
  4. Publish to NPM

Steps 1-3 are easy to reverse (even if we force push), but step 4 is not, so it's better to have it last.

Also, make sure (1) fails so if the styleguide doesn't build correctly we don't try to publish at all.

Actually, also investigate why the build is passing when the styleguide is broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lastquestion