Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move styleguide dependencies to '*' #239

Open
lastquestion opened this issue Jul 19, 2018 · 2 comments
Open

Move styleguide dependencies to '*' #239

lastquestion opened this issue Jul 19, 2018 · 2 comments

Comments

@lastquestion
Copy link
Contributor

This way when a major build goes out, the styleguide isn't broken causing the build to fail and a half published build to be out.

@karuto
Copy link
Collaborator

karuto commented Jul 23, 2018

But major changes are breaking changes, if we change dependencies to * wouldn't that break styleguide build when the package is released automatically?

@matteofigus
Copy link
Contributor

Consider that when that happens, you should expect a dependencies.io PR in max 24h (it is configured to run once a day). When that happened before it was nice because we could in case include the necessary changes as @karuto pointed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants