Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set audio/video device id that is used for testing #96

Open
szymonkups opened this issue Jan 25, 2019 · 1 comment
Open

Allow to set audio/video device id that is used for testing #96

szymonkups opened this issue Jan 25, 2019 · 1 comment

Comments

@szymonkups
Copy link

First of all - thanks for the great library.

I would like to propose a functionality that will allow setting audio and video device id that will be used during connectivity test. The reason is that sometimes participants happen to have more than one video/audio input devices installed in their system. Often (especially on Windows) happens that some of the devices are broken. We provide a device picker before the network test, where users can pick a working device and we would like to test using those picked devices.

I would be more than happy to implement this by myself and create PR. Looking forward to any guidance from the maintainers. My initial idea was to add second optional parameter (object with audioDeviceId and videoDeviceId optional string fields) to NetworkTest.testConnectivity() that will be passed down to testConectivity() -> checkPublishToSession -> checkCreateLocalPublisher. In checkCreateLocalPublisher i would validate if provided devices are part of availableDevices and use those ids as an audio/video source.

miksansegundo added a commit to meetdemio/opentok-network-test-js that referenced this issue Jul 5, 2019
miksansegundo added a commit to meetdemio/opentok-network-test-js that referenced this issue Jul 5, 2019
miksansegundo added a commit to meetdemio/opentok-network-test-js that referenced this issue Jul 5, 2019
@miksansegundo
Copy link
Contributor

@szymonkups here is what I did: #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants