Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openresty/lua #33

Open
rbtcollins opened this issue Oct 16, 2017 · 9 comments
Open

openresty/lua #33

rbtcollins opened this issue Oct 16, 2017 · 9 comments

Comments

@rbtcollins
Copy link

I'd like to suggest that openresty/lua be on the list of integrations you should actively seek contributors for.

Whats the procedure for donating such an integration, were we to make one?

@yurishkuro
Copy link
Contributor

I was not aware of OpenTracing API being available for Lua, that would be the first step before integrations.

@rbtcollins
Copy link
Author

Both are indeed necessary steps :) Whats the procedure for donating such things though?

@yurishkuro
Copy link
Contributor

yurishkuro commented Oct 16, 2017

the biggest challenge is to find some other people interested/experts in the language, so that you can collaborate on the API design to make it idiomatic for the language. OTSC members can review from OT perspective, but I, for example, won't be able to offer much advice on the language features.

Aside from that, we can create a repo and you can start hacking at it.

@rbtcollins
Copy link
Author

Just an updated, we've got the c++ based integration with nginx happening for us now, and are still looking into a native Lua implementation for more control; if/when we do that we'll come back here and request a repository once we have at least a POC working.

@james-callahan
Copy link

james-callahan commented Apr 27, 2018

I'm working on an opentracing library for Lua now.

See also opentracing/contrib#8

@frankgreco
Copy link

frankgreco commented Apr 27, 2018

I would be extremely interested in this contribution! @james-callahan do you have a link to your library?

@james-callahan
Copy link

@james-callahan do you have a link to your library?

Currently working on it over here: https://github.com/Kong/opentracing-lua

@tarekrached
Copy link

is this issue moot in light of opentracing-contrib/nginx-opentracing?

@moonming
Copy link

@tarekrached no, the opentracing-OpenResty will be implemented in Lua, and nginx-opentracing is implemented in C++.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants