Skip to content

Commit d2ee3c4

Browse files
authored
Merge pull request #10918 from Sergei-Lebedev/topic/renam_config_param
UCT/GDA: rename GPU_IB_DISTANCE_LATENCY_THRESH to GDA_MAX_SYS_LATENCY
2 parents 19615ab + 3e0ffb0 commit d2ee3c4

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

src/uct/ib/base/ib_md.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,9 +119,9 @@ ucs_config_field_t uct_ib_md_config_table[] = {
119119
"Use GPU Direct RDMA for HCA to access GPU pages directly\n",
120120
ucs_offsetof(uct_ib_md_config_t, enable_gpudirect_rdma), UCS_CONFIG_TYPE_TERNARY},
121121

122-
{"GPU_IB_DISTANCE_LATENCY_THRESH", "300ns",
122+
{"GDA_MAX_SYS_LATENCY", "300ns",
123123
"Skip GPU device if the distance latency to the IB device is greater than this value.",
124-
ucs_offsetof(uct_ib_md_config_t, ext.gpu_ib_distance_latency_thresh),
124+
ucs_offsetof(uct_ib_md_config_t, ext.gda_max_sys_latency),
125125
UCS_CONFIG_TYPE_TIME},
126126

127127
{"PCI_BW", "",

src/uct/ib/base/ib_md.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ typedef struct uct_ib_md_ext_config {
109109
unsigned long reg_retry_cnt; /**< Memory registration retry count */
110110
unsigned smkey_block_size; /**< Mkey indexes in a symmetric block */
111111
int direct_nic; /**< Direct NIC with GPU functionality */
112-
double gpu_ib_distance_latency_thresh; /**< Threshold to filter GPU<->IB distance */
112+
double gda_max_sys_latency; /**< Threshold to filter GPU<->IB distance */
113113
} uct_ib_md_ext_config_t;
114114

115115

src/uct/ib/mlx5/gdaki/gdaki.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ uct_gdaki_query_tl_devices(uct_md_h tl_md,
657657
}
658658

659659
/* TODO this logic should be done in UCP */
660-
if (dist.latency > md->super.config.gpu_ib_distance_latency_thresh) {
660+
if (dist.latency > md->super.config.gda_max_sys_latency) {
661661
continue;
662662
}
663663

test/gtest/ucp/test_ucp_device.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void test_ucp_device::get_test_variants(std::vector<ucp_test_variant> &variants)
7070
void test_ucp_device::init()
7171
{
7272
m_env.push_back(new ucs::scoped_setenv("UCX_CUDA_IPC_ENABLE_SAME_PROCESS", "y"));
73-
m_env.push_back(new ucs::scoped_setenv("UCX_IB_GPU_IB_DISTANCE_LATENCY_THRESH", "1000ns"));
73+
m_env.push_back(new ucs::scoped_setenv("UCX_IB_GDA_MAX_SYS_LATENCY", "1us"));
7474
ucp_test::init();
7575
sender().connect(&receiver(), get_ep_params());
7676
if (!is_loopback()) {

0 commit comments

Comments
 (0)