Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: note about installing under Windows #131

Merged
merged 1 commit into from
Jul 24, 2023
Merged

docs: note about installing under Windows #131

merged 1 commit into from
Jul 24, 2023

Conversation

genaris
Copy link
Contributor

@genaris genaris commented Jul 23, 2023

Adds a note about the need of a bash-compliant shell for npm/yarn install commands, important for those who want to develop using native Windows.

@genaris
docs: note about installing under Windows
62ee145 
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
berendsliedrecht
berendsliedrecht approved these changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@berendsliedrecht berendsliedrecht left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good if we can do substitution in a platform agnostic way. Maybe it would be possible to construct the command in a node.js script which would do substitution platform agnostic way.

@TimoGlastra TimoGlastra merged commit cbbedc1 into openwallet-foundation:main Jul 24, 2023
2 checks passed
@genaris genaris deleted the docs/note-on-windows branch July 24, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

@berendsliedrecht berendsliedrecht berendsliedrecht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genaris @TimoGlastra @berendsliedrecht