Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow both x5c/jwk and kid in header in JWS #2140

Open
TimoGlastra opened this issue Jan 6, 2025 · 0 comments
Open

Allow both x5c/jwk and kid in header in JWS #2140

TimoGlastra opened this issue Jan 6, 2025 · 0 comments

Comments

@TimoGlastra
Copy link
Contributor

TimoGlastra commented Jan 6, 2025

It's fine to include both. We should tweak the logic, as we now assume kid = did. But it can be a did, but also a kid that is assocaited with e.g. a jwk or a x5c.

Need to make sure it can't lead to confusion attacks, where multiple valid key references are present and they can 'trick' our implementation to (e.g. x5c is present, but we only verified the kid with a did).

So we should probably first check for either jwk or x5c. Then optionally it can have a kid but that's meaningless in that case (just an identifier). Otherwise if both are not present, we expect the kid to be a did url.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant