Jarm #2046
Draft
Jarm #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
🦋 Changeset detectedLatest commit: 2db46d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TimoGlastra
approved these changes
Sep 27, 2024
| let jarmEncryptionJwk: (JwkJson & { kid: string; use: 'enc' }) | undefined | ||
|
|
||
| if (mode === SphereonResponseMode.DIRECT_POST_JWT) { | ||
| const key = await agentContext.wallet.createKey({ keyType: KeyType.P256 }) |
There was a problem hiding this comment.
I think key type should match the key type being used to sign the request (it could even be the same key?!)
| nonce: input.nonce, | ||
| }) | ||
|
|
||
| const res = await AuthorizationRequest.fromUriOrJwt(verificationSession.authorizationRequestJwt) |
There was a problem hiding this comment.
Suggested change
| const res = await AuthorizationRequest.fromUriOrJwt(verificationSession.authorizationRequestJwt) | |
| const req = await AuthorizationRequest.fromUriOrJwt(verificationSession.authorizationRequestJwt) |
| authorizationResponsePayload = request.body | ||
| } | ||
|
|
||
| verificationSession = await getVerificationSession(agentContext, { |
There was a problem hiding this comment.
We already fetch ot above. Can't we reuse that?
| @@ -704,7 +708,7 @@ describe('OpenId4Vc', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| it('e2e flow with verifier endpoints verifying a sd-jwt-vc with selective disclosure', async () => { | |||
| it('e2e flow (jarm) with verifier endpoints verifying a sd-jwt-vc with selective disclosure', async () => { | |||
There was a problem hiding this comment.
Can we also keep a non-jarm test?
|
Oh also: should we add a simple check to make sure the jarm enc alg is supported etc? Also we don't add the required metadata params i think? |
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Signed-off-by: Martin Auer <martin.auer97@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.