Remove code to strip spaces from pg filenames when imported .def files #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works, and I did testing of other things with spaces in a PG filename and found no issues. But I have two comments:
|
|
@Alex-Jordan: I think that the comment applies to the other things that are validated and cleaned up as well on the lines that follow. As to doing the same for version 1 set definition files, if that is done, then should the file name still be trimmed? That is leading and trailing spaces removed? That is done for version 2 set definition files on lines 552 and 553. Although, perhaps it is time to think about removing support for version 1 set definition files. The only version 1 set definition files that I know of have now been removed from the OPL. |
somiaj
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #2563. I have tested with def files exported from 2.17.
I haven't checked if this works on the old format for .def files, but they haven't been used in many years.