Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Avoid setting CSS rules globally #303

Open
pandafy opened this issue Nov 26, 2024 · 3 comments · May be fixed by #317
Open

[bug] Avoid setting CSS rules globally #303

pandafy opened this issue Nov 26, 2024 · 3 comments · May be fixed by #317
Labels

Comments

@pandafy
Copy link
Member

pandafy commented Nov 26, 2024

The following rules set CSS property globally which can be problematic in downstream projects.

* {
margin: 0;
padding: 0;
outline: none;
box-sizing: border-box;
}
html,
body {
width: 100%;
height: 100%;
overflow: hidden;
font-family: Arial, sans-serif;
font-family: sans-serif;
font-size: 14px;
}

@pandafy pandafy added the bug label Nov 26, 2024
@Unnati-Gupta24
Copy link
Contributor

Hello @pandafy
I'm Unnati currently pursuing my bachelors in computers. I'm thinking we could solve this by creating a more targeted CSS approach that only affects the graph component, preventing any unexpected style conflicts. Please assign this issue to me.

@pandafy
Copy link
Member Author

pandafy commented Dec 3, 2024

@Unnati-Gupta24 you can go ahead and work on this.

@Unnati-Gupta24
Copy link
Contributor

@pandafy thank you I’ve started working on it.

Unnati-Gupta24 added a commit to Unnati-Gupta24/netjsongraph.js that referenced this issue Dec 23, 2024
Unnati-Gupta24 added a commit to Unnati-Gupta24/netjsongraph.js that referenced this issue Dec 23, 2024
Unnati-Gupta24 added a commit to Unnati-Gupta24/netjsongraph.js that referenced this issue Dec 23, 2024
Unnati-Gupta24 added a commit to Unnati-Gupta24/netjsongraph.js that referenced this issue Dec 23, 2024
Refactored CSS to prevent global styling conflicts with downstream projects. Fixes openwisp#303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants