-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"urllib" to "requests" library change #182
Conversation
…emoved the line importing json lib twice since its already imported in line 7.
… formatted using black
… and removed unused import
…rt the the updated package
While installing the requirements.txt file I faced issues when it was trying to install |
Thank you for this contribution again, I'm unfortunately currently on holidays so I won't have time to review this in details until next week. When you say that "it worked flawlessly", what did you tested specifically ? This scraper is known to have a major issue currently (#175) so I doubt you could really have tested something. And upgrading two major versions is not expected to go smoothly without any code change. Regarding the issue you faced with |
python 3.10.12 . I faced a similar issue |
Please use the proper Python version. If scraper is still on 3.8, there is 99% chance it won't work with 3.10 Or if you feel like you could do this, upgrade to more recent Python. We aim to support only one Python version per scraper, currently our target is 3.11 (zimscraperlib does not yet support 3.12). |
To be honest, I think you shouldn't spend too much time on this issue, the scraper is not working anymore and complex, you won't be able to really test your change. Taking an issue from youtube / ted / freecodecamp / kolibri / zimfarm would be more appropriate. |
Closing this for now, feel free to reopen if needed |
Fixes #180
Migrated the project from urllib to requests library. And also modified the import of
OrderedDict
anddefaultdict
from the collections framework. @benoit74 Kindly review my PR.