Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style is slightly broken #270

Open
rgaudin opened this issue Jul 26, 2022 · 14 comments
Open

Style is slightly broken #270

rgaudin opened this issue Jul 26, 2022 · 14 comments

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 26, 2022

Most likely due to an update of upstream's styles, sotoki UI doesn't render as it should.

Before
Screen Shot 2022-07-26 at 09 26 03

Now
Screen Shot 2022-07-26 at 09 25 44

This most likely affects all websites, but maybe in different ways

@rgaudin rgaudin added the bug label Jul 26, 2022
@kelson42 kelson42 added this to the 2.2.0 milestone Oct 24, 2022
@theparthshukla
Copy link

Happy to take this up on the off-chance this hasn't been fixed already.

@rgaudin
Copy link
Member Author

rgaudin commented Feb 22, 2023

It has not ; feel free to submit a PR

@theparthshukla
Copy link

theparthshukla commented Feb 22, 2023

@rgaudin Unable to reproduce the bug by generating a zim and opening with Kiwix off the main branch on a Mac. Am I missing something?

@rgaudin
Copy link
Member Author

rgaudin commented Feb 23, 2023

Ah! Indeed latest version on the library (2022-11) isn't broken anymore.

Thanks for testing!

@kelson42
Copy link
Contributor

@rgaudin Does that work out of the box, or should we make a new release to benefit of it?

@rgaudin
Copy link
Member Author

rgaudin commented Feb 23, 2023

Nothing to do. We retrieve styles from SO website.

@rgaudin
Copy link
Member Author

rgaudin commented Mar 6, 2023

@theparthshukla I still get it when running sotoki. Tried with beer.stackexchange.com, beer.meta.stackexchange and conlang.stackexchange

@rgaudin rgaudin reopened this Mar 6, 2023
@rgaudin
Copy link
Member Author

rgaudin commented Mar 6, 2023

Screenshot 2023-03-06 at 13 17 27

@theparthshukla
Copy link

@rgaudin which reader are you using? I'll try reproducing the bug again

@rgaudin
Copy link
Member Author

rgaudin commented Mar 6, 2023

Kiwix-serve (main)

@stale
Copy link

stale bot commented May 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label May 26, 2023
@stale stale bot removed the stale label Oct 29, 2023
@MUCCHU
Copy link

MUCCHU commented Dec 20, 2023

I would love to contribute to this issue, if no one's already working on it.

@rgaudin
Copy link
Member Author

rgaudin commented Dec 20, 2023

It's yours

@aryamanan
Copy link

Can I be assigned with this issue in case the issue still persists?

@benoit74 benoit74 modified the milestones: 2.1.0, 2.2.0 Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants