Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not preload subtitles in video.JS #220

Closed
benoit74 opened this issue Jul 30, 2024 · 1 comment · Fixed by #221
Closed

Do not preload subtitles in video.JS #220

benoit74 opened this issue Jul 30, 2024 · 1 comment · Fixed by #221
Assignees
@kelson42
Labels
enhancement good first issue
Milestone
3.1.0

Comments

@benoit74
Copy link
Collaborator

Just like in openzim/youtube#38 (comment), we should not preload all subtitles in video.JS component. To be confirmed how this works with native player fallback when HTML5 is not available.
@benoit74 benoit74 added this to the 3.1.0 milestone Jul 30, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Aug 2, 2024

See openzim/youtube#283, it is mostly straightforward

@kelson42 kelson42 self-assigned this Aug 3, 2024
@kelson42 kelson42 mentioned this issue Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kelson42 kelson42

Labels
enhancement good first issue
Projects
None yet
Milestone
3.1.0
Development

Successfully merging a pull request may close this issue.

Disable preloading of subtitles in video.js openzim/ted
2 participants
@kelson42 @benoit74