Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic scripts containing const and let variables are not exposed as global #398

Open
benoit74 opened this issue Sep 20, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@benoit74
Copy link
Collaborator

This is the same issue as webrecorder/wombat#82, which has been partially solved in webrecorder/wabac.js#128 (and few other commits).

Note that webrecorder/wabac.js#156 is still not addressed.

We can encounter this issue in the wild on https://geo.libretexts.org/Courses/Coastline_College/An_Introduction_To_Geology_-_Coastline_College/01%3A_Understanding_Science/1.01%3A_What_is_Science where reuse.js is exposing LibreEditor and LibreTexts.

@ikreymer: is it normal that this is not saved "already rewritten" in the WARC by wombat?

@benoit74 benoit74 added the bug Something isn't working label Sep 20, 2024
@benoit74 benoit74 self-assigned this Sep 20, 2024
@benoit74
Copy link
Collaborator Author

benoit74 commented Sep 20, 2024

Nota: webrecorder/wabac.js#156 is not encountered on libretext real use-case, importing the fix already implemented in wabac inside warc2zim would be sufficient (but I'm not sure about how to do it properly for now, I've only hacked it to check wether it was the real issue and what it would solve).

@benoit74 benoit74 removed their assignment Sep 23, 2024
@benoit74 benoit74 added this to the backlog milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant