Skip to content

Commit 05fb9cd

Browse files
authored
Merge pull request #935 from openzim/fix_zimit_keep
Zimit keep flag was set but not declared in Offliner definition
2 parents f1f2327 + 72b53c4 commit 05fb9cd

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

dispatcher/backend/src/common/schemas/offliners/zimit.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,17 @@ class Meta:
432432
required=False,
433433
)
434434

435+
keep = fields.Boolean(
436+
truthy=[True],
437+
falsy=[False],
438+
metadata={
439+
"label": "Keep",
440+
"description": "Should be True. Developer option: must be True if we want "
441+
"to keep the WARC files for artifacts archiving.",
442+
},
443+
required=False,
444+
)
445+
435446
output = String(
436447
metadata={
437448
"label": "Output folder",

dispatcher/backend/src/utils/offliners.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ def command_for(offliner, flags, mount_point):
7878
if offliner == Offliner.zimit:
7979
if "adminEmail" not in flags:
8080
flags["adminEmail"] = "contact+zimfarm@kiwix.org"
81-
flags["keep"] = True # always keep temporary files, they will be deleted anyway
81+
if "keep" not in flags:
82+
# always keep temporary files, they will be deleted anyway
83+
flags["keep"] = True
8284

8385
_command_for_set_default_publisher(flags, offliner_def)
8486

0 commit comments

Comments
 (0)