Skip to content

Commit 2de33a5

Browse files
authored
Merge pull request #52 from openzim/fix_offliner_flags
Zimfarm endpoint now contains flags as subkey in dictionary
2 parents f054dbe + 6a292a7 commit 2de33a5

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

ui/src/components/NewRequest.vue

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@
112112
},
113113
computed: {
114114
editorReady() {
115-
return this.form && this.offliner_def !== null; },
115+
return this.form && this.offliner_flags !== null; },
116116
form_fields() {
117117
let fields = [];
118-
for (var i=0;i<this.offliner_def.length;i++) {
119-
let field = this.offliner_def[i];
118+
for (var i=0;i<this.offliner_flags.length;i++) {
119+
let field = this.offliner_flags[i];
120120
let component = "b-form-input";
121121
let options = null;
122122
let component_type = null;
@@ -195,7 +195,7 @@
195195
},
196196
methods: {
197197
loadRecipeDefinition(force_reload, on_success, on_error) {
198-
if (!force_reload && this.$store.getters.offliner_def.length){
198+
if (!force_reload && this.$store.getters.offliner_flags.length){
199199
if (on_success) { on_success(); }
200200
return;
201201
}
@@ -205,8 +205,7 @@
205205
parent.toggleLoader("fetching definition…");
206206
parent.queryAPI('get', Constants.zimfarm_webapi + '/offliners/zimit')
207207
.then(function (response) {
208-
let definition = response.data.filter(field => Constants.zimit_fields.indexOf(field.key) > -1);
209-
parent.$store.dispatch('setOfflinerDef', definition);
208+
parent.$store.dispatch('setOfflinerDef', response.data);
210209
211210
if (on_success) { on_success(); }
212211
})

ui/src/components/mixins.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default {
88
},
99
computed: {
1010
publicPath() { return process.env.BASE_URL; }, // for static files linking
11-
offliner_def() { return this.$store.getters.offliner_def; }, // offliner def for requests
11+
offliner_flags() { return this.$store.getters.offliner_flags; }, // offliner flags for requests
1212
},
1313
methods: {
1414
toggleLoader(text) { // shortcut to store's loader status changer

ui/src/store.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11

22
import Vue from 'vue'
33
import Vuex from 'vuex'
4+
import Constants from './constants.js'
45

56
Vue.use(Vuex);
67

@@ -9,7 +10,7 @@ const store = new Vuex.Store({
910
loading: false,
1011
loading_text: "",
1112

12-
offliner_def: [],
13+
offliner_def: null,
1314
},
1415
mutations: {
1516
setLoading (state, payload) { // toggle GUI loader
@@ -31,6 +32,12 @@ const store = new Vuex.Store({
3132
getters: {
3233
loadingStatus(state) { return {should_display: state.loading, text: state.loading_text};},
3334
offliner_def(state) { return state.offliner_def; },
35+
offliner_flags(state) {
36+
if (!state.offliner_def) {
37+
return []
38+
}
39+
return state.offliner_def.flags.filter(field => Constants.zimit_fields.indexOf(field.key) > -1);
40+
},
3441
}
3542
})
3643

0 commit comments

Comments
 (0)