Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit download size for user-input URLs #67

Open
rgaudin opened this issue Jul 26, 2024 · 1 comment
Open

Limit download size for user-input URLs #67

rgaudin opened this issue Jul 26, 2024 · 1 comment
Labels
question Further information is requested

Comments

@rgaudin
Copy link
Member

rgaudin commented Jul 26, 2024

With illustration already and behaviors soon (maybe?), our worker can be ordered to download arbitrary URLs without stopping at any specific size. That's a potential hazard.

We should check how the crawler enforces the limit we use as well ; it could be a simple post-write check which might be vulnerable as well.

@rgaudin rgaudin added the question Further information is requested label Jul 26, 2024
@benoit74
Copy link
Collaborator

Agreed, this is a "significant" security concern. Probably something to solve in scraper (or scraperlib even).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants