Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track refactoring of "aws.origin" tag #172

Open
codefromthecrypt opened this issue May 30, 2020 · 0 comments
Open

Track refactoring of "aws.origin" tag #172

codefromthecrypt opened this issue May 30, 2020 · 0 comments

Comments

@codefromthecrypt
Copy link
Member

From @anuraaga on #171 cc @iamsouravin

One high level note is origin can actually be inferred by other tags, if we were to actually populate them.

The segment has an aws struct here

https://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html#api-segmentdocuments-aws

So instead of origin, we could process tags like this into the segment for a more complete picture (and origin could be inferred)

aws.beanstalk.environment_name
aws.beanstalk.version_label
aws.beanstalk.deployment_id
aws.ecs.container
aws.ec2.instance_id
aws.ec2.availability_zone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant