Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SDK V2 brave Instrumentation support for SQS #174

Open
JaidenAshmore opened this issue May 31, 2020 · 1 comment
Open

AWS SDK V2 brave Instrumentation support for SQS #174

JaidenAshmore opened this issue May 31, 2020 · 1 comment

Comments

@JaidenAshmore
Copy link

The existing support for tracing via message attributes of an SQS message only appear to support the v1 API and it would be great to have v2 support, see https://github.com/openzipkin/zipkin-aws/tree/master/brave-instrumentation/aws-java-sdk-sqs for the v1 implementation.

I have currently been working on this myself and just creating tests so I will create a Pull Request when it is ready.
JaidenAshmore added a commit to JaidenAshmore/zipkin-aws that referenced this issue Jun 1, 2020
@JaidenAshmore
refs openzipkin#174: adds AWS SDK V2 instrumentation support for SQS …
b468fdc 
…messages

This will allow tracing information to be included in the
message attributes of the SQS messages so traces can
be continued by the service consuming this message.
@nigelmenger
Copy link

@JaidenAshmore Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JaidenAshmore @nigelmenger