Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rip out google auth #153

Open
codefromthecrypt opened this issue Sep 25, 2019 · 4 comments
Open

rip out google auth #153

codefromthecrypt opened this issue Sep 25, 2019 · 4 comments

Comments

@codefromthecrypt
Copy link
Member

During #119, we noticed there's still a dependency on google's oauth library which is getting subverting our dependency management. What's happening is it has not only a strict dep on census, but census itself starts dragging in other grpc libraries.

Exception in thread "AsyncReporter{StorageComponent}" java.lang.NoClassDefFoundError: io/grpc/Context
	at io.opencensus.trace.CurrentSpanUtils.getCurrentSpan(CurrentSpanUtils.java:37)
	at io.opencensus.trace.Tracer.spanBuilder(Tracer.java:308)
	at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:848)
	at com.google.auth.oauth2.ServiceAccountCredentials.refreshAccessToken(ServiceAccountCredentials.java:429)

Notably the maintainers of google's http library marked my bug as a "question" even after someone else acked this is a problem googleapis/google-http-java-client#621

@anuraaga
Copy link
Collaborator

@saturnism Can you follow up on the upstream bug? It's probably a net loss for everyone if users roll their own auth because the auth library got too bloated.

@codefromthecrypt
Copy link
Member Author

agreed. also it is both an issue of bloat and more importantly pinning to unstable libraries. That said, because this is a leaf module for us, it is more about bloat because we have no plans to use the libraries they are pinning to internally.

@elefeint
Copy link
Contributor

I am following up internally (Ray is finally on vacation!)

@codefromthecrypt
Copy link
Member Author

sadly this is still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants