Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support zipkin server behind a proxy in HttpLogger #205

Closed
zephinzer opened this issue Apr 15, 2018 · 3 comments
Closed

Support zipkin server behind a proxy in HttpLogger #205

zephinzer opened this issue Apr 15, 2018 · 3 comments

Comments

@zephinzer
Copy link

zephinzer commented Apr 15, 2018 •
edited
Loading

Problem
We have two networks (let A and B) that can only communicate with each other through a proxy gateway. When specifying the address to the Zipkin server in network B from an application in network A, the HttpLogger is attempting to connect directly without going through the proxy, resulting in a failure to post the trace.

Problem experienced using version 0.12.0 of the zipkin-transport-http package using Node v8.10.0 for Ubuntu 16.04.

Solution
I am working on implementing the solution outlined in the node-fetch repository under node-fetch Options to be able to specify a http.agent in the fetch parameter.
zephinzer added a commit to zephinzer/zipkin-js that referenced this issue Apr 15, 2018
@zephinzer
[openzipkin#205] added proxy argument for routing HttpLogger through …
67d0dbb 
…a proxy

- [package.json] added http/s proxy agents to dependencies
- [package.json] added proxy middleware for express to test proxy behaviour
- [HttpLogger.js] added proxy parameter in constructor
- [HttpLogger.js] added createProxyAgentIfAvailable() instance method
- [HttpLogger.js] added agent property to accept proxy agent
- [integrationTest.js] replicated existing tests using a simulated proxy server
@zephinzer zephinzer changed the title Support HTTP[S]_PROXY in HttpLogger Support zipkin server behind a proxy in HttpLogger Apr 15, 2018
zephinzer added a commit to zephinzer/zipkin-js that referenced this issue Apr 16, 2018
@zephinzer
[openzipkin#205] added proxy argument for routing HttpLogger through …
970b365 
…a proxy

- [package.json] added http/s proxy agents to dependencies
- [package.json] added proxy middleware for express to test proxy behaviour
- [HttpLogger.js] added proxy parameter in constructor
- [HttpLogger.js] added createProxyAgentIfAvailable() instance method
- [HttpLogger.js] added agent property to accept proxy agent
- [integrationTest.js] replicated existing tests using a simulated proxy server
- using http-proxy-middleware instead of express-http-proxy for tests because of conflict with restify
- fixed eslint issue
@zephinzer zephinzer mentioned this issue Apr 16, 2018
Closed
@jcchavezs
Copy link
Contributor

@zephinzer are you still interested on this?

@jcchavezs
Copy link
Contributor

jcchavezs commented Nov 27, 2019 •
edited
Loading

@zephinzer I think this solved this issue, isn't? #439. Can we close this issue?

@jcchavezs
Copy link
Contributor

Closing it as I think it was adressed already. Please @zephinzer feel free to reopen if you think it was not addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds proxy argument for routing HttpLogger through a proxy zephinzer/zipkin-js
2 participants
@jcchavezs @zephinzer