From a64301096e9d92e5a7171a41eba2f53be59109a9 Mon Sep 17 00:00:00 2001 From: Benjamin Hugot Date: Thu, 26 Jul 2018 15:34:00 +0200 Subject: [PATCH] Some comments --- .../Src/Transport/Http/TracingHandler.cs | 20 ++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs b/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs index 177e5f9..b1c4aa4 100644 --- a/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs +++ b/Src/zipkin4net/Src/Transport/Http/TracingHandler.cs @@ -12,11 +12,22 @@ public class TracingHandler : DelegatingHandler private readonly string _serviceName; private readonly Func _getClientTraceRpc; + /// + /// Create a Tracing Handler + /// + /// + /// if not set or null then it set an as inner handler + /// public TracingHandler(string serviceName, HttpMessageHandler httpMessageHandler = null, Func getClientTraceRpc = null) : this(Propagations.B3String.Injector((carrier, key, value) => carrier.Add(key, value)), serviceName, httpMessageHandler ?? new HttpClientHandler(), getClientTraceRpc) { } - + /// + /// Create a TracingHandler for injection purpose like HttpClientFactory in AspNetCore + /// + /// + /// + /// public static TracingHandler WithoutInnerHandler(string serviceName, Func getClientTraceRpc = null) => new TracingHandler(Propagations.B3String.Injector((carrier, key, value) => carrier.Add(key, value)), serviceName, getClientTraceRpc); @@ -27,6 +38,13 @@ private TracingHandler(IInjector injector, string serviceName, Http _serviceName = serviceName; _getClientTraceRpc = getClientTraceRpc ?? (request => request.Method.ToString()); } + + /// + /// Constructor used to create the handler without an inner handler. + /// + /// + /// + /// private TracingHandler(IInjector injector, string serviceName, Func getClientTraceRpc = null) { _injector = injector;