Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Notification #859

Closed
michaelquigley opened this issue Feb 10, 2025 · 1 comment
Closed

Upgrade Notification #859

michaelquigley opened this issue Feb 10, 2025 · 1 comment
Assignees
Labels
enhancement Enhancement of an existing feature spike Requires R&D; figure it out
Milestone

Comments

@michaelquigley
Copy link
Collaborator

Can we change the /api/v1/version protocol to provoke an upgrade message, even for older clients?

@michaelquigley michaelquigley self-assigned this Feb 10, 2025
@michaelquigley michaelquigley added enhancement Enhancement of an existing feature spike Requires R&D; figure it out labels Feb 10, 2025
@michaelquigley michaelquigley added this to the v0.4 milestone Feb 10, 2025
@michaelquigley
Copy link
Collaborator Author

michaelquigley commented Feb 10, 2025

For v1.0.0 we can alter the /api/v1/version GET method to return an out of date message, rather than a proper version. The protocol will shift such that /api/v1/version accepts a POST, which validates the client version for compatibility, which is probably a better long-term solution, as it gives the server side control over what client versions are compatible.

Existing zrok clients will receive an error message like this:

$ zrok04 share public -b web .
[ERROR]: unable to create share (error getting zrok client: expected a 'v0.4' version, received: 'your zrok version is out of date and needs to be upgraded! please visit 'https://github.com/openziti/zrok/releases' for the latest build!')

The v1.x releases will maintain the old GET endpoint, which will continue to provoke out-of-date clients to upgrade until we version the entire spec, at which point it could be removed.

@michaelquigley michaelquigley modified the milestones: v0.4, v1.0 Feb 10, 2025
@michaelquigley michaelquigley moved this from Development to Evaluating in zrok Development Roadmap Feb 10, 2025
michaelquigley added a commit that referenced this issue Feb 10, 2025
michaelquigley added a commit that referenced this issue Feb 10, 2025
@michaelquigley michaelquigley moved this from Evaluating to Done in zrok Development Roadmap Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature spike Requires R&D; figure it out
Projects
Development

No branches or pull requests

1 participant