diff --git a/app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivityPresenter.kt b/app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivityPresenter.kt index 4975bd21b5a..530b208e897 100644 --- a/app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivityPresenter.kt +++ b/app/src/main/java/org/oppia/android/app/player/exploration/ExplorationActivityPresenter.kt @@ -221,7 +221,6 @@ class ExplorationActivityPresenter @Inject constructor( context.startActivity(intent) true } - R.id.action_help -> { val intent = HelpActivity.createHelpActivityIntent( activity, @@ -232,7 +231,6 @@ class ExplorationActivityPresenter @Inject constructor( context.startActivity(intent) true } - else -> false } } @@ -294,13 +292,11 @@ class ExplorationActivityPresenter @Inject constructor( when (it) { is AsyncResult.Pending -> oppiaLogger.d("ExplorationActivity", "Stopping exploration") - is AsyncResult.Failure -> { oppiaLogger.e("ExplorationActivity", "Failed to stop exploration", it.error) // Allow the user to always exit if they get into a broken state. backPressActivitySelector() } - is AsyncResult.Success -> { oppiaLogger.d("ExplorationActivity", "Successfully stopped exploration") maybeShowSurveyDialog(profileId, topicId) @@ -380,7 +376,6 @@ class ExplorationActivityPresenter @Inject constructor( ) EphemeralExploration.getDefaultInstance() } - is AsyncResult.Pending -> EphemeralExploration.getDefaultInstance() is AsyncResult.Success -> ephemeralExpResult.value } @@ -390,7 +385,6 @@ class ExplorationActivityPresenter @Inject constructor( when (parentScreen) { ExplorationActivityParams.ParentScreen.TOPIC_SCREEN_LESSONS_TAB, ExplorationActivityParams.ParentScreen.STORY_SCREEN -> activity.finish() - ExplorationActivityParams.ParentScreen.PARENT_SCREEN_UNSPECIFIED, ExplorationActivityParams.ParentScreen.UNRECOGNIZED -> { // Default to the topic activity. @@ -507,7 +501,6 @@ class ExplorationActivityPresenter @Inject constructor( oldestCheckpointExplorationTitle = it.value.explorationTitle } } - is AsyncResult.Failure -> { oppiaLogger.e( "ExplorationActivity", @@ -515,7 +508,6 @@ class ExplorationActivityPresenter @Inject constructor( it.error ) } - is AsyncResult.Pending -> {} // Wait for an actual result. } } @@ -543,12 +535,10 @@ class ExplorationActivityPresenter @Inject constructor( learnerAnalyticsLogger.explorationAnalyticsLogger.value?.logLessonSavedAdvertently() stopExploration(isCompletion = false) } - CheckpointState.CHECKPOINT_SAVED_DATABASE_EXCEEDED_LIMIT -> { learnerAnalyticsLogger.explorationAnalyticsLogger.value?.logLessonSavedAdvertently() showProgressDatabaseFullDialogFragment() } - else -> showUnsavedExplorationDialogFragment() } } @@ -564,7 +554,6 @@ class ExplorationActivityPresenter @Inject constructor( null, is AsyncResult.Pending -> { oppiaLogger.d("ExplorationActivity", "A gating decision is pending") } - is AsyncResult.Failure -> { oppiaLogger.e( "ExplorationActivity", @@ -573,7 +562,6 @@ class ExplorationActivityPresenter @Inject constructor( ) backPressActivitySelector() } - is AsyncResult.Success -> { if (gatingResult.value) { val dialogFragment = diff --git a/app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivityPresenter.kt b/app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivityPresenter.kt index ab63038024b..b09e77fdfce 100644 --- a/app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivityPresenter.kt +++ b/app/src/main/java/org/oppia/android/app/resumelesson/ResumeLessonActivityPresenter.kt @@ -119,7 +119,6 @@ class ResumeLessonActivityPresenter @Inject constructor( ) Profile.getDefaultInstance() } - is AsyncResult.Pending -> { oppiaLogger.d( "ResumeLessonActivity", @@ -127,7 +126,6 @@ class ResumeLessonActivityPresenter @Inject constructor( ) Profile.getDefaultInstance() } - is AsyncResult.Success -> profileResult.value }.readingTextSize }