Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change option name for "Default Audio" to "Preferred Audio Language" #4649

Closed
vrajdesai78 opened this issue Oct 12, 2022 · 11 comments · Fixed by #5165
Closed

Change option name for "Default Audio" to "Preferred Audio Language" #4649

vrajdesai78 opened this issue Oct 12, 2022 · 11 comments · Fixed by #5165
Assignees
@theMr17
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@vrajdesai78
Copy link
Contributor

vrajdesai78 commented Oct 12, 2022 •
edited by seanlip
Loading

Describe the bug
Change the "Default audio" text in the Options menu to be clearer.

To Reproduce
Steps to reproduce the behavior:

  1. Open exploration player
  2. Click on Options

Expected behavior
The "default audio" text should be changed to "Preferred Audio Language".

Current Screen
image

[Note: This was edited by @seanlip from the original content description based on https://github.com//issues/4649#issuecomment-1731676351]
@vrajdesai78 vrajdesai78 reopened this Oct 12, 2022
@rt4914
Copy link
Contributor

rt4914 commented Oct 25, 2022

@vrajdesai78 not part of GSoC

@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). enhancement End user-perceivable enhancements. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Aug 11, 2023
@adhiamboperes adhiamboperes added Impact: Low Low perceived user impact (e.g. edge cases). good first issue This item is good for new contributors to make their pull request. and removed Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). labels Sep 7, 2023
@geektan123
Copy link

Assign#4649

@adhiamboperes
Copy link
Collaborator

@BenHenning do we still need to work on this given the proposed changes in the revised onboarding flow?

@seanlip
Copy link
Member

seanlip commented Sep 22, 2023 •
edited
Loading

From the PM side: I think it is worth making this menu clearer regardless of the onboarding flow. I think "Reading Text Size" is fine but "Default Audio" is unclear. Could we change it to "Preferred Audio Language" instead?

@adhiamboperes
Copy link
Collaborator

I am fine with rewording to Preferred Audio Language

@seanlip seanlip changed the title No context for what default reading text size and default audio is Change option name for "Default Audio" to "Preferred Audio Language" Sep 22, 2023
@seanlip
Copy link
Member

seanlip commented Sep 22, 2023

Thanks @adhiamboperes -- updated the title and description of the issue accordingly. This should be a pretty good starter issue, I think!

@adhiamboperes
Copy link
Collaborator

Sure, @geektan123, if you'd like to attempt to fix this, please let me have a description of your proposed solution.

@theMr17
Copy link
Collaborator

theMr17 commented Sep 28, 2023

Hi @adhiamboperes, I would like to work on this issue. I will fix this by changing the audio_language string in strings.xml file to Preferred Audio Language. Also, the string needs to be changed in other translations as well.

According to me, the toolbar title also needs to be changed accordingly.

@adhiamboperes
Copy link
Collaborator

@the-mr17, you only need to update the text in the english strings file. @translatewiki will update any translations. Otherwise the approach sg.

@adhiamboperes
Copy link
Collaborator

@the-mr17 I had assigned #5079 to you. If you won't be working on it please let me know.

@theMr17
Copy link
Collaborator

theMr17 commented Sep 29, 2023

@the-mr17 I had assigned #5079 to you. If you won't be working on it please let me know.

@adhiamboperes My apologies for the delay. I have just added a PR addressing that issue. PTAL.

@theMr17 theMr17 mentioned this issue Sep 30, 2023
Merged
6 tasks
adhiamboperes pushed a commit that referenced this issue Oct 1, 2023
@theMr17
Fix #4649: Updates audio option name (#5165)
716d3a0 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

Fixes #4649

This PR changes the `audio_language` & `audio_language_activity_title`
string in `strings.xml` file to `Preferred Audio Language`.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing

<img
src="https://github.com/oppia/oppia-android/assets/84731134/ee45c13d-5181-4cc8-991c-73a204884eae"
width="300"/>
<img
src="https://github.com/oppia/oppia-android/assets/84731134/b4cc6942-43fa-45f5-8dd0-081eeae7b064"
width="300"/>
@adhiamboperes adhiamboperes added the Hacktoberfest This is a suggested Hacktoberfest issue. label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theMr17 theMr17

Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4649: Updates audio option name theMr17/oppia-android
6 participants
@rt4914 @seanlip @vrajdesai78 @adhiamboperes @theMr17 @geektan123