Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the unused condition from various lessons_chapters_view for Accessibility #4909

Closed
MohitGupta121 opened this issue Mar 18, 2023 · 0 comments · Fixed by #4910
Closed

Remove the unused condition from various lessons_chapters_view for Accessibility #4909

MohitGupta121 opened this issue Mar 18, 2023 · 0 comments · Fixed by #4910
Assignees
@MohitGupta121
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@MohitGupta121
Copy link
Member

MohitGupta121 commented Mar 18, 2023 •
edited
Loading

Currently we using viewModel.chapterPlayState != ChapterPlayState.NOT_PLAYABLE_MISSING_PREREQUISITES condition ForAccessibility which is always True in lessons_in_progress_chapter_view.xml , lessons_no_started_chapter_view.xml and always False in lessons_locked_chapter_view.xml

So we can remove this condition and directly use the true value.
@MohitGupta121 MohitGupta121 self-assigned this Mar 18, 2023
@MohitGupta121 MohitGupta121 mentioned this issue Mar 18, 2023
Merged
6 tasks
@adhiamboperes adhiamboperes added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed Type: Improvement labels Jun 15, 2023
adhiamboperes pushed a commit that referenced this issue Jul 4, 2023
@MohitGupta121
Fix #4909 : Remove the unused condition from various lessons_chapters…
f93c06b 
…_view for Accessibility (#4910)

## Explanation

Fixed #4909 : Remove the unused conditions from
`lessons_no_started_chapter_view.xml`
`lessons_in_progress_chapter_view.xml` `lessons_locked_chapter_view.xml`
for Accessibility.

Fixed a bug where TalkBack would read chapter names twice when the chapter is locked, and also improved the feedback read out when a locked chapter is clicked 


## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4909 : Remove the unused condition from various lessons_chapters_view for Accessibility
2 participants
@adhiamboperes @MohitGupta121