Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page #5170

Closed
theMr17 opened this issue Sep 23, 2023 · 7 comments · Fixed by #5167
Closed

[Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page #5170

theMr17 opened this issue Sep 23, 2023 · 7 comments · Fixed by #5167
Assignees
@Vishwajith-Shettigar
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@theMr17
Copy link
Collaborator

theMr17 commented Sep 23, 2023

Is your feature request related to a problem? Please describe.

A loading bar would be good to indicate the user that the topics are being loaded on the home page.

Describe the solution you'd like

I would like to have a simple indeterminate circular progress at the center of the screen when the topics are loading.

Describe alternatives you've considered

No response

Additional context

Screen.Recording.mp4
@Vishwajith-Shettigar
Copy link
Collaborator

Vishwajith-Shettigar commented Sep 30, 2023 •
edited
Loading

i have made a draft PR #5167 for this feature request.
@adhiamboperes Could you please take a look at this?

Merged
6 tasks
@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Oct 1, 2023 •
edited
Loading

i have made a draft PR #5167 for this feature request. @adhiamboperes Could you please take a look at this?

We don't have loading progressbars in our current design system, so I don't think we can add a solution for this without product and design team input, to decide whether we want this in the first place.

@adhiamboperes adhiamboperes changed the title [Feature Request]: Display loading bar when topics are loading in Home Page [Feature Request]: Display loading bar when topics are loading in Home Page [Blocked on Product] Oct 1, 2023
@adhiamboperes
Copy link
Collaborator

@seanlip, PTAL for product.

@seanlip
Copy link
Member

seanlip commented Oct 1, 2023

This needs design input. Moving it to the design team, thanks for the suggestion @the-mr17.

@seanlip seanlip transferred this issue from oppia/oppia-android Oct 1, 2023
@seanlip seanlip removed their assignment Oct 1, 2023
@seanlip seanlip changed the title [Feature Request]: Display loading bar when topics are loading in Home Page [Blocked on Product] [Feature Request]: Display loading bar when topics are loading in Home Page Oct 1, 2023
@seanlip seanlip changed the title [Feature Request]: Display loading bar when topics are loading in Home Page [Feature Request]: Display some kind of loading animation/graphic when topics are loading in Home Page Oct 1, 2023
@seanlip
Copy link
Member

seanlip commented Oct 1, 2023

Note to design team ( /cc @jiwonc26 ) -- @Vishwajith-Shettigar made a PR with this fix:

Record_2023-10-01-22-53-42_943a62cb4c6fb83e010e1c2e82766a17.mp4

What do you think about it?

@jiwonc26
Copy link

jiwonc26 commented Oct 2, 2023

Note to design team ( /cc @jiwonc26 ) -- @Vishwajith-Shettigar made a PR with this fix:

Record_2023-10-01-22-53-42_943a62cb4c6fb83e010e1c2e82766a17.mp4

What do you think about it?

I like this! Looks def better

@seanlip seanlip transferred this issue from oppia/design-team Oct 2, 2023
@seanlip
Copy link
Member

seanlip commented Oct 2, 2023

OK, thanks! Moving this back to the oppia-android repo then since the proposed solution looks good to the design team.

@theMr17 theMr17 added Impact: Low Low perceived user impact (e.g. edge cases). enhancement End user-perceivable enhancements. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Oct 6, 2023
adhiamboperes pushed a commit that referenced this issue Oct 14, 2023
@Vishwajith-Shettigar
Fix #5170 [Feature Request]: Display some kind of loading animation/g…
1496445 
…raphic when topics are loading in Home Page (#5167)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fix #5170. Added progressbar to the home fragment to
show loading.
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

Light mode


https://github.com/oppia/oppia-android/assets/76042077/d7ac57cb-47e0-43a1-b80c-7c64eaa67ddd

Darkmode


https://github.com/oppia/oppia-android/assets/76042077/1a13dd22-df4d-4dbd-bd06-19882a123d98




<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
5 participants
@seanlip @adhiamboperes @jiwonc26 @Vishwajith-Shettigar @theMr17