Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not https://github.com/opspec-pkgs/docker.build.image ? #5

Open
chrisdostert opened this issue Jan 28, 2019 · 2 comments
Open

why not https://github.com/opspec-pkgs/docker.build.image ? #5

chrisdostert opened this issue Jan 28, 2019 · 2 comments

Comments

@chrisdostert
Copy link
Contributor

chrisdostert commented Jan 28, 2019

I think this should be merged w/ https://github.com/opspec-pkgs/docker.image.build.

All it would take is making imageTar optional and adding optional dockerSocket param

The trouble is, socket params can't have defaults so this isn't currently possible.

Just keeping this here to revisit in future

@apexskier
Copy link
Contributor

@chrisdostert
Copy link
Contributor Author

chrisdostert commented Apr 28, 2020

sorry meant https://github.com/opspec-pkgs/docker.image.build; fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants