Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parameters in function call check_termination in pccg_solver.py #97

Open
KuKi2121 opened this issue Aug 10, 2023 · 0 comments
Open

Comments

@KuKi2121
Copy link

Dear pao-Team,

thank you for the development of this amazing package! :)
I would like to report a minor bug in the function check_termination in pccg_solver.py.
If execute_PCCG_solver reaches its iteration-limit and the terminition is checked, while the solver config.quiet-parameter is set True, check_termination is called and raises the RuntimeError(f'Error: Upper bound greater than lower bound after {k} iterations and {elapsed} seconds: Obj={LB} UB={UB}'). However, this is resulting in a NameError as k (and elapsed) is not provided to the check_termination-function.
If PRs are considered, I would be happy to solve this Issue.

Thank you in advance!
Best,
Kirill Kuroptev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant