Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absent instrumentation tags in WriteLocalVariableNode and Python call nodes with one to four arguments. #280

Open
Yuhala opened this issue Sep 16, 2022 · 0 comments
Open

Absent instrumentation tags in WriteLocalVariableNode and Python call nodes with one to four arguments. #280

Yuhala opened this issue Sep 16, 2022 · 0 comments

Comments

@Yuhala
Copy link

Yuhala commented Sep 16, 2022

The com.oracle.graal.python.nodes.frame.WriteLocalVariableNode class does not override the hasTag method which provides the corresponding instrumentation tags. Same issue with the four nested classes: PythonCallUnary, PythonCallBinary, PythonCallTernary and PythonCallQuaternary of the com.oracle.graal.python.nodes.call.PythonCallNode class.

I will be opening a pull request with proposed fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yuhala