Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate check for existing finalizer #8

Open
al3xandru opened this issue Jan 27, 2022 · 1 comment
Open

Remove duplicate check for existing finalizer #8

al3xandru opened this issue Jan 27, 2022 · 1 comment

Comments

@al3xandru
Copy link

(Minor) Method AddFinalizers is doing a check if the finalizer is already present before delegating to controllerutil.AddFinalizer. The implementation of controllerutil.AddFinalizer is doing that check too already: https://github.com/kubernetes-sigs/controller-runtime/blob/7ba3e559790c5e3543002a0d9670b4cef3ccf743/pkg/controller/controllerutil/controllerutil.go#L351
@jayasheelankumar
Copy link
Member

@al3xandru, Thanks for pointing. We will update the logic in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@al3xandru @jayasheelankumar