Code uses non-C99 compliant constructs

[michael-o]

1. What version of ODPI-C are you using (see dpi.h)?
   5.6.4

2. What OS (and version) is your application on?
   HP-UX 11.31

3. What compiler (and version) did you use?
   HP aCC 06.29

4. What is your version of the Oracle Client (e.g. Instant Client)? How was it installed? Where it is installed?
   Full Oracle Client 19

5. What is your Oracle Database version?
   Oracle 19 SE2

What problem or error(s) you are seeing?

Current code uses anonymous unions in a struct which are a compiler extension and are not C99 compliant. The HP aCC trips over that and refuses to compile.

Here is a fix: main...michael-o:odpi:c99-compliance

Works on LLVM and HP aCC.

You can simulate the issue on LLVM or GCC by setting: EXTRA_CFLAGS ?= -std=c99 -pedantic

[anthony-tuininga]

Thanks for the report! I'll take a look and get this resolved.

[michael-o]

Thanks for the report! I'll take a look and get this resolved.

Report and diff for python-oracledb is in the works.

[michael-o]

@anthony-tuininga Did you get a chance to look at this?

[anthony-tuininga]

I just took a look. Messing with the API is undesirable except in version 6.0 as it requires all downstream users to adjust. I saw you did that for python-oracledb but there are quite a few others! Since the old names (when the structure was called dpiSodaCollNames) are deprecated anyway they would simply be dropped and the unions would go away completely. So my suggestion is to do that instead. We are planning on dropping support for Oracle Client libraries earlier than 19 anyway in version 6.0. Timing is yet to be discussed!

[michael-o]

I just took a look. Messing with the API is undesirable except in version 6.0 as it requires all downstream users to adjust. I saw you did that for python-oracledb but there are quite a few others! Since the old names (when the structure was called dpiSodaCollNames) are deprecated anyway they would simply be dropped and the unions would go away completely. So my suggestion is to do that instead. We are planning on dropping support for Oracle Client libraries earlier than 19 anyway in version 6.0. Timing is yet to be discussed!

Makes sense, but this could be cherry-picked: c822c74 WDYT?

[anthony-tuininga]

Yes, it could. I'll pull that at least. I presume, however, that is simply a warning and not a hard error?

[michael-o]

Yes, it could. I'll pull that at least. I presume, however, that is simply a warning and not a hard error?

Correct, it is a warning.